[Bromley][Waste] Handle common DD reconcile cases in script. - #5844
Conversation
31b0183 to
1ab0740
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5844 +/- ##
==========================================
- Coverage 83.40% 83.40% -0.01%
==========================================
Files 500 500
Lines 37316 37334 +18
Branches 6166 6167 +1
==========================================
+ Hits 31125 31137 +12
- Misses 4381 4388 +7
+ Partials 1810 1809 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f9794d4 to
0ea9403
Compare
0ea9403 to
53fdde1
Compare
9a3969f to
ce4bb86
Compare
ce4bb86 to
557236d
Compare
72dc828 to
09633b0
Compare
dracos
left a comment
There was a problem hiding this comment.
One tiny thing is all, and doesn't actually matter.
I guess next step would be doing the same the other way round (for --force-new) and have it check it's new. Then I wonder if we can actually combine the renewal/new handling so that it's not needed at all and we can only have one loop through that finds a 'relevant' report (regardless if DD is new or renew) and does something, but could that cause a problem somehow. You'd hope not, because there shouldn't be the 'other' thing in either case...
| $self->log("no matching record found for $category payment with id " . $payment->payer); | ||
| } | ||
|
|
||
| unless ( $handled ) { |
In case they came in wrong. See mysociety/societyworks#4806.
For when there's no matching service in Echo. See mysociety/societyworks#4806.
557236d to
9117d7e
Compare
https://github.com/mysociety/societyworks/issues/4806
[skip changelog]