Skip to content

[Bromley][Waste] Handle common DD reconcile cases in script. - #5844

Merged
neprune merged 3 commits into
masterfrom
bromley-reconcile-dd-handle-common-cases
Jun 5, 2026
Merged

[Bromley][Waste] Handle common DD reconcile cases in script.#5844
neprune merged 3 commits into
masterfrom
bromley-reconcile-dd-handle-common-cases

Conversation

@neprune

@neprune neprune commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Comment thread t/cobrand/bromley_waste.t Outdated
@neprune
neprune force-pushed the bromley-reconcile-dd-handle-common-cases branch from 31b0183 to 1ab0740 Compare February 11, 2026 20:31
@codecov

codecov Bot commented Feb 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.40%. Comparing base (9fcac04) to head (9117d7e).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Roles/Cobrand/DDProcessor.pm 93.33% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5844      +/-   ##
==========================================
- Coverage   83.40%   83.40%   -0.01%     
==========================================
  Files         500      500              
  Lines       37316    37334      +18     
  Branches     6166     6167       +1     
==========================================
+ Hits        31125    31137      +12     
- Misses       4381     4388       +7     
+ Partials     1810     1809       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@neprune
neprune force-pushed the bromley-reconcile-dd-handle-common-cases branch 6 times, most recently from f9794d4 to 0ea9403 Compare February 12, 2026 18:05
@dracos
dracos force-pushed the bromley-reconcile-dd-handle-common-cases branch from 0ea9403 to 53fdde1 Compare February 13, 2026 09:01
@neprune
neprune force-pushed the bromley-reconcile-dd-handle-common-cases branch 3 times, most recently from 9a3969f to ce4bb86 Compare February 13, 2026 13:29
@neprune
neprune requested a review from dracos February 13, 2026 13:30
@dracos
dracos force-pushed the bromley-reconcile-dd-handle-common-cases branch from ce4bb86 to 557236d Compare February 18, 2026 14:51
@dracos
dracos force-pushed the master branch 2 times, most recently from 72dc828 to 09633b0 Compare March 9, 2026 18:46

@dracos dracos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thing is all, and doesn't actually matter.

I guess next step would be doing the same the other way round (for --force-new) and have it check it's new. Then I wonder if we can actually combine the renewal/new handling so that it's not needed at all and we can only have one loop through that finds a 'relevant' report (regardless if DD is new or renew) and does something, but could that cause a problem somehow. You'd hope not, because there shouldn't be the 'other' thing in either case...

$self->log("no matching record found for $category payment with id " . $payment->payer);
}

unless ( $handled ) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be only one unless block

@neprune
neprune force-pushed the bromley-reconcile-dd-handle-common-cases branch from 557236d to 9117d7e Compare June 5, 2026 11:14
@neprune
neprune merged commit 9117d7e into master Jun 5, 2026
21 checks passed
@neprune
neprune temporarily deployed to github-pages June 5, 2026 11:16 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants