fix(android): Fix marker images disappearing after CodePush update#179
Merged
mym0404 merged 2 commits intomym0404:mainfrom Dec 31, 2025
Hidden character warning
The head ref may contain hidden characters: "bugfix/Android\uc5d0\uc11c-Codepush-\uc774\ud6c4-Required\ub85c-\ucc38\uc870\ud558\ub294-Marker\uac00-\uc0ac\ub77c\uc9d1\ub2c8\ub2e4"
Conversation
Contributor
Author
|
@mym0404 요거 한번 검토해주실 수 있을까요? |
Owner
|
안녕하세요, 기여감사합니다. 현재 iOS에선 문제가 없는지 여쭤보고싶습니다. ktlint만 통과하게 해주실수있을까요? origin/main 을 merge 하시고 진행하시면 됩니다. |
Contributor
Author
@mym0404 넵 ios에서는 정상동작했습니다. |
…fter CodePush - Add support for file:// and content:// URI formats in rnAssetUri - Fix marker image loading logic to properly handle CodePush bundle URIs - Update drawable resource condition to exclude URI-formatted rnAssetUri
- Rename httpUri variable to assetUri to reflect that it handles multiple URI formats - The variable now correctly represents file://, content://, http://, and https:// URIs - Improves code readability and consistency with rnAssetUri naming
sean5940
force-pushed
the
bugfix/Android에서-Codepush-이후-Required로-참조하는-Marker가-사라집니다
branch
from
6c6a9e1 to
22f569e
Compare
Contributor
Author
|
@mym0404 병합 완료했습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What does this change?
file://andcontent://URIs from CodePush bundleshttpUritoassetUrifor better code clarityFixes #57 🎯