feat: add tests to connection binding on gateway objects#229
Merged
bruno-martins-mx merged 1 commit intomasterfrom Jan 14, 2025
Merged
feat: add tests to connection binding on gateway objects#229bruno-martins-mx merged 1 commit intomasterfrom
bruno-martins-mx merged 1 commit intomasterfrom
Conversation
bruno-martins-mx
force-pushed
the
bm/mc-144
branch
from
8c89061 to
5a83849
Compare
mattnichols
reviewed
Jan 9, 2025
| then: | ||
| result instanceof BehaviorWithConfigurationAndConnection | ||
| verifyAll((BehaviorWithConfigurationAndConnection) result) { | ||
| connectionWithBoundConfiguration |
Collaborator
There was a problem hiding this comment.
Should we check some of the values in the connection as well?
Contributor
Author
There was a problem hiding this comment.
Good point. Check added.
bruno-martins-mx
force-pushed
the
bm/mc-144
branch
from
5a83849 to
951132c
Compare
mattnichols
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add test cases to
ConnectionBinderand binding ofConnectionson gateway objects.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: