add raw_status, aggregator and selected_account_id in events#106
Closed
sophtron-jishun wants to merge 1 commit intomxenabled:masterfrom
Closed
add raw_status, aggregator and selected_account_id in events#106sophtron-jishun wants to merge 1 commit intomxenabled:masterfrom
sophtron-jishun wants to merge 1 commit intomxenabled:masterfrom
Conversation
sophtron-jishun
requested review from
Jameson13B,
ash-wright123,
codingLogan,
mwclemy and
wesrisenmay-mx
as code owners
Jameson13B
reviewed
Apr 15, 2025
Comment on lines
+122
to
+125
| if (ucpInstitutionId) { | ||
| event.ucpInstitutionId = ucpInstitutionId | ||
| } |
Collaborator
There was a problem hiding this comment.
I know this was already named in another MR that has been merged but moving forward we are wanting to not reference MX/UCP/UCW/etc in the code. Just for future FYI.
Jameson13B
reviewed
Apr 15, 2025
Jameson13B
reviewed
Apr 15, 2025
Jameson13B
reviewed
Apr 15, 2025
Jameson13B
reviewed
Apr 15, 2025
Author
|
@Jameson13B fixed according to the comments |
Collaborator
|
Taking this PR over and moving it to a branch instead of a fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is to support ucw-app requirements Universal-Connect-Project/ucw-app#216
as well as adding missing aggregator information in memberStatusUpdate events