Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds frontend support to the pgmanager application by integrating a WebAssembly-based user interface built with Bootstrap. The changes introduce build tags to conditionally include the frontend, restructure HTTP handlers to separate backend API endpoints from frontend serving, and update the build process to compile the WASM frontend.
Key changes:
- Added WebAssembly frontend with Bootstrap UI framework and navigation
- Refactored HTTP handlers to support conditional frontend inclusion via build tags
- Updated build pipeline (Makefile and Dockerfile) to compile and embed the frontend
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| wasm/pgmanager/wasmbuild.yaml | Configuration for WASM build with Bootstrap CDN dependencies |
| wasm/pgmanager/main.go | WASM frontend entry point with navigation controller |
| pkg/manager/httphandler/httphandler.go | Renamed RegisterHandlers to RegisterBackendHandlers for clarity |
| pkg/manager/httphandler/frontend_excluded.go | Fallback handler when frontend build tag is not set |
| pkg/manager/httphandler/frontend.go | Frontend file server handler when frontend build tag is set |
| pkg/manager/httphandler/doc.go | Updated documentation to reflect renamed function |
| cmd/pgmanager/server.go | Updated to use renamed backend handler and new frontend handler |
| Makefile | Added WASM build support and pgmanager target with frontend embedding |
| etc/Dockerfile | Updated to install wasmbuild tool and build with frontend |
| go.mod | Added gRPC and protobuf dependencies for frontend support |
| etc/go.mod | New frontend module configuration |
| etc/embed.go | Embedded filesystem for frontend static files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds frontend support to the pgmanager application by integrating a WebAssembly-based user interface built with Bootstrap. The changes introduce build tags to conditionally include the frontend, restructure HTTP handlers to separate backend API endpoints from frontend serving, and update the build process to compile the WASM frontend.