Declare the MUSE_COMPILE_USE_PCH option app-side - #34791
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe top-level Merge Risk: ⚪ Minimal · up to The build configuration now retains precompiled headers as enabled by default after the framework update. The change is ready to merge with no identified current risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Full details: Description checkExplanation The description includes the issue reference, change rationale, impact, and completed checklist. The unit-test checkbox is left unchecked, which is reasonable for this CMake-only declaration if no test applies. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolves: musescore/muse_framework#254
musescore/muse_framework#254 removes the
MUSE_COMPILE_USE_PCHdeclaration from the framework so applications own the option (MUSE_COMPILE_USE_UNITYis already declared app-side here). Declaring it is safe before that PR merges (same ON default, first declaration wins) and required after it — otherwise PCH silently turns off when the framework is updated.