Skip to content

Declare the MUSE_COMPILE_USE_PCH option app-side - #34791

Open
luapmartin wants to merge 1 commit into
musescore:mainfrom
luapmartin:app-side-pch-option
Open

Declare the MUSE_COMPILE_USE_PCH option app-side#34791
luapmartin wants to merge 1 commit into
musescore:mainfrom
luapmartin:app-side-pch-option

Conversation

@luapmartin

@luapmartin luapmartin commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Resolves: musescore/muse_framework#254

musescore/muse_framework#254 removes the MUSE_COMPILE_USE_PCH declaration from the framework so applications own the option (MUSE_COMPILE_USE_UNITY is already declared app-side here). Declaring it is safe before that PR merges (same ON default, first declaration wins) and required after it — otherwise PCH silently turns off when the framework is updated.

  • I signed the CLA
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 9d1dfde3-55e1-4d1a-9285-fa3ace95b1c3

📥 Commits

Reviewing files that changed from the base of the PR and between 3276ec6 and 38b1509.

📒 Files selected for processing (1)
  • CMakeLists.txt

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The top-level CMakeLists.txt adds the MUSE_COMPILE_USE_PCH option. The option defaults to ON and controls precompiled header usage.

Merge Risk: ⚪ Minimal · up to 38b15

The build configuration now retains precompiled headers as enabled by default after the framework update. The change is ready to merge with no identified current risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: declaring the MUSE_COMPILE_USE_PCH option on the application side.
Description check ✅ Passed The description includes the issue reference, change rationale, impact, and completed checklist. The unit-test checkbox is left unchecked, which is reasonable for this CMake-only declaration if no tes…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description includes the issue reference, change rationale, impact, and completed checklist. The unit-test checkbox is left unchecked, which is reasonable for this CMake-only declaration if no test applies.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant