4.7 ports

[miiizen]

Ports: #32944
Ports: #32947

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: d5179223-6c41-49af-b50a-f1ad291c2308

📥 Commits

Reviewing files that changed from the base of the PR and between 6f59207 and 2443c91.

📒 Files selected for processing (11)

• src/engraving/compat/engravingcompat.cpp
• src/engraving/compat/engravingcompat.h
• src/engraving/dom/lyrics.cpp
• src/engraving/dom/utils.cpp
• src/engraving/dom/utils.h
• src/engraving/editing/textedit.cpp
• src/engraving/rendering/score/lyricslayout.cpp
• src/notation/internal/notationinteraction.cpp
• src/notationscene/qml/MuseScore/NotationScene/editpercussionshortcutmodel.cpp
• vtest/scores/lyrics-32.mscz
• vtest/scores/lyrics-33.mscz

💤 Files with no reviewable changes (1)

• src/engraving/rendering/score/lyricslayout.cpp

---

📝 Walkthrough

Walkthrough

This pull request refactors lyrics line visibility synchronization across the engraving system. It introduces a new utility function findPrevPartialLyricsLineDash() to locate associated PartialLyricsLine spanners, implements pre-4.7.0 score compatibility handling via setLyricLineVisibility(), and updates lyrics removal and visibility logic. Changes include modifications to Lyrics::setProperty() for visibility handling, updates to lyrics editing and navigation code to use the centralized helper function, and removal of redundant visibility assignment in lyrics layout. A translation header dependency was also added to percussion editing code.

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description only provides links to two ported PRs without filling required template sections like motivation, checklist confirmation, or a description of changes.	Complete the PR description template by adding motivation for the changes, checking the required checkboxes, and providing a substantive explanation of what is being ported.
Docstring Coverage	⚠️ Warning	Docstring coverage is 30.77% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title '4.7 ports' is vague and overly generic, using non-descriptive terms that do not convey meaningful information about the specific changes in the changeset.	Replace with a more descriptive title that highlights the primary change, such as 'Add lyrics line visibility independence and compatibility layer for <4.70 scores' or similar.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}