Port #32963

[mike-spa]

Port: #32963

Summary by CodeRabbit

• Bug Fixes
  • Refined positioning of diminuendo hairpin markings in music scores for improved visual alignment.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2bbf18df-c6d7-4a3c-b5a2-07fec26ec846

📥 Commits

Reviewing files that changed from the base of the PR and between 2a47884 and 1874305.

📒 Files selected for processing (1)

• src/palette/internal/palettecreator.cpp

---

📝 Walkthrough

Walkthrough

The hairpin cell offset calculation in PaletteCreator::newDynamicsPalette is refined to assign distinct offsets based on hairpin type. CRESC_LINE retains QPointF(1, 0.25), DIM_LINE now uses QPointF(1, 0.0) instead of the previous shared offset, and other hairpin types keep QPointF(0, 0).

Changes

Cohort / File(s)	Summary
Hairpin Cell Offset Adjustment src/palette/internal/palettecreator.cpp	Refactored hairpin cell offset logic from binary check to three-way conditional to apply type-specific offsets: CRESC_LINE maintains QPointF(1, 0.25), DIM_LINE changes to QPointF(1, 0.0), others remain QPointF(0, 0).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Align cresc and dim in palette #32963 — Modifies the same function to set distinct hairpin offsets for CRESC_LINE and DIM_LINE with identical offset values.

Suggested reviewers

• miiizen

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description is incomplete, containing only 'Port: #32963' without addressing required template sections like motivation, CLA confirmation, or testing details.	Fill in the PR description template with issue reference, motivation for changes, checklist confirmations, and testing verification.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Port #32963' is vague and non-descriptive; it references an issue number but does not convey what the actual change is.	Replace with a descriptive title summarizing the actual change, such as 'Adjust hairpin cell offsets for DIM_LINE dynamics'.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}