[4.7.0] MuseSampler: send breath marks#32932
Merged
RomanPudashkin merged 1 commit intomusescore:4.7from Apr 8, 2026
Merged
Conversation
📝 WalkthroughWalkthroughThis PR introduces support for Breath articulations across the playback system, including parsing breath marks from chords, defining the articulation type in the MPE framework, mapping it to string representations, adding profile patterns for voice and winds, and integrating with the MuseSampler sequencer for audio synthesis. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 74b5903d-1e15-4f99-9ca9-b1a374b50053
📒 Files selected for processing (8)
src/engraving/playback/metaparsers/chordarticulationsparser.cppsrc/engraving/playback/metaparsers/chordarticulationsparser.hsrc/framework/mpe/internal/articulationstringutils.hsrc/framework/mpe/mpetypes.hsrc/framework/mpe/resources/general_voice_articulations_profile.jsonsrc/framework/mpe/resources/general_winds_articulations_profile.jsonsrc/framework/musesampler/internal/apitypes.hsrc/framework/musesampler/internal/musesamplersequencer.cpp
mathesoncalum
approved these changes
Apr 7, 2026
sampleeditor
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.