Skip to content

Added missing preferences focus handlers#32929

Open
grliszas14 wants to merge 2 commits intomusescore:masterfrom
grliszas14:prefs_auto_scroll
Open

Added missing preferences focus handlers#32929
grliszas14 wants to merge 2 commits intomusescore:masterfrom
grliszas14:prefs_auto_scroll

Conversation

@grliszas14
Copy link
Copy Markdown
Contributor

Added missing preferences focus handlers (so it auto scrolls when using navigation).
Fixed Import->MEI navigation section (it wasn't possible to navigate to it)

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1bc10cd1-b226-4693-98f2-b3899562da1e

📥 Commits

Reviewing files that changed from the base of the PR and between 4e25547 and cc01ca1.

📒 Files selected for processing (12)
  • src/preferences/qml/MuseScore/Preferences/AdvancedPreferencesPage.qml
  • src/preferences/qml/MuseScore/Preferences/AudioMidiPreferencesPage.qml
  • src/preferences/qml/MuseScore/Preferences/BraillePreferencesPage.qml
  • src/preferences/qml/MuseScore/Preferences/CanvasPreferencesPage.qml
  • src/preferences/qml/MuseScore/Preferences/FoldersPreferencesPage.qml
  • src/preferences/qml/MuseScore/Preferences/GeneralPreferencesPage.qml
  • src/preferences/qml/MuseScore/Preferences/ImportPreferencesPage.qml
  • src/preferences/qml/MuseScore/Preferences/NoteInputPreferencesPage.qml
  • src/preferences/qml/MuseScore/Preferences/PercussionPreferencesPage.qml
  • src/preferences/qml/MuseScore/Preferences/SaveAndPublishPreferencesPage.qml
  • src/preferences/qml/MuseScore/Preferences/ScorePreferencesPage.qml
  • src/preferences/qml/MuseScore/Preferences/UpdatePreferencesPage.qml

📝 Walkthrough

Walkthrough

Multiple preference page QML files were updated to add focus-driven visibility behavior. Specifically, onFocusChanged handlers were added to various preference section components across eleven preference pages. When a section gains focus, these handlers call root.ensureContentVisibleRequested() with the section's geometry to request parent-level scrolling or visibility management. Additionally, ImportPreferencesPage.qml adds navigation metadata to MeiSection and updates MnxSection's navigation order.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main objective of the changeset: adding missing focus handlers to preferences pages for auto-scroll functionality during navigation.
Description check ✅ Passed The PR description provides context for the changes, explains the motivation (auto-scrolling during navigation), addresses both issues (focus handlers and MEI navigation fix), and includes a completed checklist. Most required template items are satisfied.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants