feat(runtime): add marshalling of value structs#93
Merged
baszalmstra merged 6 commits intomun-lang:masterfrom Mar 7, 2020
Merged
feat(runtime): add marshalling of value structs#93baszalmstra merged 6 commits intomun-lang:masterfrom
baszalmstra merged 6 commits intomun-lang:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 76.82% 77.22% +0.39%
==========================================
Files 122 124 +2
Lines 9601 9816 +215
==========================================
+ Hits 7376 7580 +204
- Misses 2225 2236 +11
Continue to review full report at Codecov.
|
Collaborator
|
I would say we call the original function in the wrapper/bridge function. |
added 6 commits
March 7, 2020 10:58
A function cannot be marshalled when one of its parameters or its return type are a value struct
d1868b4 to
3a716ad
Compare
Collaborator
Author
baszalmstra
approved these changes
Mar 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@baszalmstra Can you check whether my approach is valid?What is a good way to implement the generation of the wrapper? Should it be a copy of the body of the statically linked version, or should it just dereference thestruct(value)parameters and pass it to the original function?