feature: refactored RawItems into ItemTree#271
Merged
baszalmstra merged 1 commit intomun-lang:masterfrom Sep 23, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
- Coverage 79.05% 79.05% -0.01%
==========================================
Files 214 217 +3
Lines 12808 12941 +133
==========================================
+ Hits 10125 10230 +105
- Misses 2683 2711 +28
Continue to review full report at Codecov.
|
Wodann
requested changes
Sep 20, 2020
Collaborator
Wodann
left a comment
There was a problem hiding this comment.
Nice refactor. I don't have anything to improve, except a typo in the comments.
3d22b2d to
d25a997
Compare
Wodann
approved these changes
Sep 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First refactor to remove RawItems and create better separation of concerns. ItemTree is a derived AST that only contains module items. All interning is now done as ItemTree ids instead of building directly on the AST. Hopefully, this creates a clearer separation between items and the AST.
When adding modules (which Im also working on) having this ItemTree is much clearer than using either RawItems or the code model or a strange combination. Im not sure yet how to handle the
TypeRefSourceMap, Im looking into removing that too.