misc: removed float, int, uint#157
Merged
baszalmstra merged 2 commits intomun-lang:masterfrom May 2, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 82.74% 82.69% -0.06%
==========================================
Files 162 162
Lines 11137 11115 -22
==========================================
- Hits 9215 9191 -24
- Misses 1922 1924 +2
Continue to review full report at Codecov.
|
Wodann
requested changes
May 2, 2020
Wodann
approved these changes
May 2, 2020
8230d9f to
124cf19
Compare
Wodann
approved these changes
May 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
int,uintandfloattypes.These types are superseded by the concrete types
i32,u32andf64types. Initially, we felt that people don't care about bitness but we came to the conclusion that we needed to implement sized types as well. Once those were in place we found that thefloat,int,uinttypes were verbose and no longer required.There is a seperate PR to remove them from the book.