[codemod] Remove use of eval()#48701
Open
oliviertassinari wants to merge 1 commit into
Open
Conversation
oliviertassinari
added
package: codemod
Deploy previewhttps://deploy-preview-48701--material-ui.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
Janpot
approved these changes
Jun 22, 2026
Janpot
left a comment
Janpot
left a comment
Member
There was a problem hiding this comment.
Suggestion: deduplicate
const apply = (operator, value) => ...
// ...
param = j.literal(apply(operator, value));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eval() was not required since we do a
j.BinaryExpression.check(https://astexplorer.net/#/gist/afd7a9826b74db48e14cfa176a8f113f/7c6e9cc95649922afdf546aef7238d947f70af74 so we can remove it.Now, this codemod logic is 7 years old; it was added in #15782, it's never run anymore, but having an eval() raises questions: https://groups.google.com/a/mui.com/g/security/c/SpAXHq8xkAM. So we might as well remove it.