Add support for KnowGo Adaptation Layer events#279
Open
pmundt wants to merge 3 commits intomuesli:masterfrom
Open
Add support for KnowGo Adaptation Layer events#279pmundt wants to merge 3 commits intomuesli:masterfrom
pmundt wants to merge 3 commits intomuesli:masterfrom
Conversation
CalmBit
reviewed
Dec 14, 2019
Collaborator
CalmBit
left a comment
CalmBit
left a comment
There was a problem hiding this comment.
LGTM, aside from the one small documentation point I pointed out. I don't know enough about this personally to approve it, but I can't see anything I'd reject!
rubiojr
reviewed
Dec 18, 2019
Owner
|
Looks good to me, too, apart from @rubiojr's comment. Let's try not to spam the console too much. In the meantime I'm working on a logger module that lets you browse/filter by each bee's individual output. That should improve the situation quite a bit. |
Author
|
I've now switched it over to the debug logger, as requested. |
Owner
|
One issue we got here is depending on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial attempt at getting notifications from our backend into the system, which we plan to expand with additional events and actions over time.