Ensure Recorder is mounted in handleRecordingDuration function - #764
Open
angekouf wants to merge 1 commit into
Open
Ensure Recorder is mounted in handleRecordingDuration function#764angekouf wants to merge 1 commit into
handleRecordingDuration function#764angekouf wants to merge 1 commit into
Conversation
Author
|
This solves issue #728 |
|
Bump as I still have this issue. Can we merge the commit? |
|
LGTM @muaz-khan |
Author
|
I have rebased the branch to use the latest version of the repo @muaz-khan |
|
This would be great, can't use setRecordingDuration because of this |
|
@muaz-khan Are you still maintaining this repo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a check in the
handleRecordingDurationfunction to make sure the Recorder is still mounted when the callback to the setTimeout is called.This is needed because if the Recorder is unmounted after the recording ends and the user stops the recording before reaching the time limit, then an error occurs since
selfisnull.