Conversation
|
oooOOOOOoooooh. This is very exciting. Really great work @carlosperate 🎉 Something to hit with a big stick during EuroPython sprints. 😁 🇪🇺 🐍 |
|
This pull request introduces 1 alert when merging 794e7e7 into 5be0c29 - view on LGTM.com new alerts:
|
858f18d to
87c3b5a
Compare
|
This pull request introduces 1 alert when merging 87c3b5a into 9fe47ac - view on LGTM.com new alerts:
|
f9f8801 to
ce72b95
Compare
a338a3c to
e4bbb38
Compare
9efdd96 to
dc50e2f
Compare
And update the CI test configuration.
cclauss
left a comment
There was a problem hiding this comment.
Nice to see!!! 57 checks on every pull request seems like a lot of complexity to manage and a lot of CPU to burn. Of course, we want all these platforms to work in the long run but are there some platforms that are easier so we can get mu on PyQt6 working end-to-end on a few. Awesome effort!
| python-version: '3.5' | ||
| - os: ubuntu-latest | ||
| python-version: '3.6' | ||
| python-version: ['3.8', '3.9', '3.10', '3.11'] |
There was a problem hiding this comment.
| python-version: ['3.8', '3.9', '3.10', '3.11'] | |
| python-version: ['3.8', '3.9', '3.10', '3.11', ‘3.12’] |
| timeout-minutes: 5 | ||
|
|
||
| test-arm: | ||
| # Missing Qt6 versions of: python3-pyqt5.qsci python3-pyqt5.qtchart |
There was a problem hiding this comment.
Has this situation improved?
| if: false | ||
| runs-on: ubuntu-latest | ||
| name: Test Py 3.7 - arm-debian-buster | ||
| name: Test Py 3.10 - arm-debian-bookworm |
There was a problem hiding this comment.
Is bookworm’s default Python 3.10 or 3.11?
| name: Test Py 3.7 - arm-debian-buster | ||
| name: Test Py 3.10 - arm-debian-bookworm | ||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
| - uses: actions/checkout@v3 | |
| - uses: actions/checkout@v4 |
| python -m pip config list && | ||
| python -m pip list && | ||
| python -m pip install .[dev] && | ||
| python -m pip install cryptography pyzmq cffi --python-version 3.9 --only-binary \":all:\" --no-deps --target venv/lib/python3.10/site-packages/ && |
There was a problem hiding this comment.
This line creates a Py3.9 binary and puts into the Py3.10 site packages?
| # which are needed for the main editor to function. | ||
| # | ||
| "PyQt5==5.13.2" | ||
| "PyQt6==6.3.1" |
There was a problem hiding this comment.
| "PyQt6==6.3.1" | |
| "PyQt6==6.6.1" |
| "PyQt6==6.3.1" | ||
| + ';"arm" not in platform_machine and "aarch" not in platform_machine', | ||
| "QScintilla==2.11.3" | ||
| "PyQt6-QScintilla==2.13.3" |
There was a problem hiding this comment.
| "PyQt6-QScintilla==2.13.3" | |
| "PyQt6-QScintilla==2.14.1" |
| "PyQt6-QScintilla==2.13.3" | ||
| + ';"arm" not in platform_machine and "aarch" not in platform_machine', | ||
| "PyQtChart==5.13.1" | ||
| "PyQt6-Charts==6.3.1" |
There was a problem hiding this comment.
| "PyQt6-Charts==6.3.1" | |
| "PyQt6-Charts==6.6.0" |
| "mu.wheels", | ||
| ], | ||
| python_requires=">=3.5,<3.9", | ||
| python_requires=">=3.7,<3.12", |
There was a problem hiding this comment.
| python_requires=">=3.7,<3.12", | |
| python_requires=">=3.8,<3.13", |
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", |
There was a problem hiding this comment.
| "Programming Language :: Python :: 3.11", | |
| "Programming Language :: Python :: 3.11", | |
| "Programming Language :: Python :: 3.12", |
This is a work in progress, so the tests are still failing, but Mu is launching.
Some useful links:
One current issue: