Skip to content

Conversation

@yl-whosit
Copy link

  • set signs param2 to colorfacedir
  • make signs use a color palette and hardware coloring
  • add poster coloring crafting recipes and optional depend on dye
    screenshot_posters

- make signs use a color palette and hardware coloring
- add poster coloring crafting recipes and optional depend on dye
@Niklp09 Niklp09 self-requested a review March 30, 2025 18:50
Copy link
Member

@Niklp09 Niklp09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!

Would be nice if you could try to follow the code style of the project, it looks broken both in codium and on gh.

Compress the new textures, they're unreasonably large.
I usually use

alias op='find . -type f -iname "*.png" -not -iname "screenshot*" -exec optipng -o7 -zm1-9 -nc -strip all -clobber {} \;'

signs/crafts.lua Outdated
Comment on lines 51 to 61
if minetest.registered_items["dye:red"] then
local dyes = {
"dye:white",
"dye:grey",
"dye:orange",
"dye:brown",
"dye:dark_grey",
"dye:yellow",
"dye:green",
"dye:red",
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signs/crafts.lua Outdated
Comment on lines 63 to 71
minetest.register_craft({
type = "shaped",
output = minetest.itemstring_with_palette("signs:paper_poster", (i-1) * 32),
recipe = {
{ "signs:paper_poster", dye, "" },
{ "", "", "" },
{ "", "", "" },
}
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go w/ shapeless, since using shapeless crafting isn't a performance problem anymore. (you decide:)

Suggested change
minetest.register_craft({
type = "shaped",
output = minetest.itemstring_with_palette("signs:paper_poster", (i-1) * 32),
recipe = {
{ "signs:paper_poster", dye, "" },
{ "", "", "" },
{ "", "", "" },
}
})
minetest.register_craft({
type = "shapeless",
output = minetest.itemstring_with_palette("signs:paper_poster", (i-1) * 32),
recipe = {"signs:paper_poster", dye}
})

@yl-whosit
Copy link
Author

yl-whosit commented Mar 30, 2025

Sorry about space/tab mix, I had to hunt down those spaces using emacs whitespace-mode - should invest some time so it at least gives me a warning... (also: I could not see any indentation issues anywhere - even github showed it like properly formatted :/)

Please tell me if there are any other issues.

Also please squash :D

@yl-whosit
Copy link
Author

I'm also now wondering if those textures are a little too rough, and should be made a smidge lighter (seemed to fit "medieval" theme we have on YL :p)

Copy link
Member

@Niklp09 Niklp09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to check for xcompat as it is a hard dependency, LGTM otherwise.
Thanks!

@yl-whosit
Copy link
Author

Oops, fixed.

@Niklp09 Niklp09 merged commit 0ec62a1 into mt-mods:master Mar 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants