TSL: Automatically render non-texture nodes in .toInspector(). - #34534
Open
justkahdri wants to merge 1 commit into
Open
TSL: Automatically render non-texture nodes in .toInspector().#34534justkahdri wants to merge 1 commit into
justkahdri wants to merge 1 commit into
Conversation
- `.toInspector()` now wraps non-texture nodes in `rtt()` when the inspector builds them, so users no longer have to do it manually. Texture and pass nodes are presented as they are. The RTT is created once per inspector node and reused, nested inspector nodes are not processed while rendering it. - `before()` is now honored by intent var nodes, `Fn()` calls, `isolate()` and `subBuild()`, which bypass `Node.build()`. Without this `.toInspector()` was silently ignored on operator results and function calls. - `InspectorNode` is exported from `TSL.js` instead of `TSLBase.js` to avoid a circular import through `RTTNode`.
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea came up while talking with @sunag in person.
Description
.toInspector()currently requires manually wrapping non-texture nodes inrtt()to display them reliably. This change creates and reuses an RTT automatically when the inspector displays a non-texture node. Texture and pass nodes keep their existing behavior.It also ensures that operator results,
Fn()calls,isolate()andsubBuild()honorNode.before(), so their.toInspector()calls are registered. The inspector export moves toTSL.jsto avoid a circular import throughRTTNode.Testing
Lint, build, core unit tests and addon unit tests pass. Generated bundles are not included. The Inspector UI has not been verified in a WebGPU browser.