Examples: Improve webgpu_lines_fat.html#33498
Examples: Improve webgpu_lines_fat.html#33498WestLangley wants to merge 2 commits intomrdoob:devfrom
Conversation
|
@gkjohnson Are the artifacts still prominent? |
Yes the artifacts re still present on my machine. You can see them by setting the CSS background to white and enabling a2c.
-- Regarding the example, I find the curved lines to be much more appealing to look at, though I understand the dashed lines don't look great. I also want to make sure that this is a separate effort from and not blocking those being discussed in #33437, #33457, and #33369, which are ready to be either merged or closed. |
I agree. Can you make the GUI updates without changing the visual aspects of the demo? |
If the dashes do not work well on curvy lines we should either remove the feature or fix it. We don't know how the users generates lines and if we provide a dashed style it should work with any curvature. |
Well, removing support for dashes is an option. (Follow the instructions in the first line of the original post in this thread as see how horrible it is.) Users will likely not be happy with the removed feature, as there are uses cases where the dashes look OK -- such as the use case in this PR. |
|
I don't think every feature option needs to be perfectly and universally supported among all option combinations. I also don't think we need to "hide" these kinds of functional deficiencies in the examples. Users can determine whether the effect is suitable for their use case for themselves and the example makes the limitations apparent. Though I do think it would be an improvement to reduce the default "world units" width to fit the scale of the scene better, as has been done here. -- In terms of improving the "dash" effect even with small segments: the dash end caps could be rounded just as the segment shapes are, which would hide the artifacts resulting from angles between the sections. |


Look at the current example and toggle on "world-units" and "dashed".
Current example: https://threejs.org/examples/webgpu_lines_fat.html
This PR modifies the GUI to ensure the parameters are reasonable.
Updated example: https://raw.githack.com/westlangley/three.js/dev-webgpu_lines_fat/examples/webgpu_lines_fat.html
//
Also, although the existing example looks pretty, the line segments are too short relative to the end-caps, so the example is not typical. This PR fixes that, too.
If approved, the related examples can be updated in a similar fashion.