TSL: Fix stack node sequence#33402
Merged
sunag merged 8 commits intomrdoob:devfrom Apr 29, 2026
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32872, Related #31929 (comment)
Description
Insert the Node sequence based on the current stack context; this should fix issues where
.toStack()may be out of sync with the process of related sub-stacks, which is common in conditional loop nodes.This should fix the reason why
positionLocalwas executing before the vertex transformations, https://github.com/mrdoob/three.js/wiki/Three.js-Shading-Language#position and #32873 (comment)/cc @PoseidonEnergy