GLTFLoader: Add KHR_mesh_primitive_restart#33401
Draft
donmccurdy wants to merge 2 commits intomrdoob:devfrom
Draft
GLTFLoader: Add KHR_mesh_primitive_restart#33401donmccurdy wants to merge 2 commits intomrdoob:devfrom
donmccurdy wants to merge 2 commits intomrdoob:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For discussion of a proposed glTF extension, supporting primitive restart values in line loop, line strip, triangle strip, and triangle fan topologies:
Because three.js requires WebGL 2, no actual rendering changes are required, this PR just ensures that GLTFLoader recognizes the extension name. The
KHR_mesh_primitive_restartproposal is meant to replace the existingEXT_mesh_primitive_restartextension, which would be more complex and less efficient to support in three.js.This contribution is funded by Bentley Systems.