Fix: Safari compatibility for documentation navigation#32576
Closed
CHENJIAMIAN wants to merge 1 commit intomrdoob:devfrom
Closed
Fix: Safari compatibility for documentation navigation#32576CHENJIAMIAN wants to merge 1 commit intomrdoob:devfrom
CHENJIAMIAN wants to merge 1 commit intomrdoob:devfrom
Conversation
a3df777 to
6da73e4
Compare
- Updated page.js template to not add className prefix for TSL and Global pages - This fixes the issue where navigation sidebar links pointed to wrong anchors - Previously clicking "Break" in TSL would look for id="TSL.Break" instead of id="Break" - Only modified the template file, as docs/ folder is auto-generated Fixes mrdoob#32302 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
6da73e4 to
1e3d77c
Compare
Collaborator
|
This change does not fix the issue for me. Testing with Safari on a macMini. I have searched for Since there is already another PR trying to fix the issue, please do not create new ones. If you want to contribute, share your thoughts in #32312. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed Safari browser navigation issues in three.js documentation across all sections (TSL, Global, and Core pages). Enhanced scroll handling specifically for Safari's iFrame navigation behavior while maintaining compatibility with other browsers.
Problem
Safari users experienced navigation failures where clicking documentation entries would show the wrong page portion or fail to scroll to the correct sections. This affected:
Root Cause Analysis
The issue was not hash generation logic, but Safari's implementation of:
scrollIntoView()within iFramesSolution
safariScrollToElement()with fallback methodsTest Environment
Technical Implementation
Fixes #32302
Addresses @Mugen87 feedback on Safari compatibility