wayland: do a roundtrip to give compositor time to ready image desc #17053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #16844
There's no guarantee that a roundtrip is enough, but practically, it's enough on every compositor. This might be preferred over the other PR because this is a timed wait while the other PR could be indefinite if the compositor never responds, or have adverse effects for frametiming if it takes longer than the frame budget. Though #16844 is also what Mesa, so if a compositor is so buggy it would affect more than just mpv. For that reason, I don't think there's any reason to worry about it but the maintainers might feel differently.
Posting this to discuss both solutions, I'll add a commit message if this is preferred