feat: Update Urban Airship to version 19.x#31
Merged
BrandonStalnaker merged 3 commits intodevelopmentfrom Mar 19, 2025
Merged
Conversation
rmi22186
reviewed
Mar 19, 2025
rmi22186
reviewed
Mar 19, 2025
rmi22186
reviewed
Mar 19, 2025
rlepinski
reviewed
Mar 19, 2025
| self->_started = YES; | ||
|
|
||
| UAConfig *config = [UAConfig defaultConfig]; | ||
| UAConfig *config = [UAConfig config]; |
Contributor
There was a problem hiding this comment.
Oh dang, so this is going to change some behavior that I am not sure if anyone is relying on. defaultConfig loads the plist values into the config if available. config is just a factory method. We did not expose a defaultConfig version so we can either not worry about, wait for the next release, or we can add some code here to try to use the loadFromplist method.
Contributor
Author
There was a problem hiding this comment.
@rlepinski What if we did something like this?
Suggested change
| UAConfig *config = [UAConfig config]; | |
| NSError *error = nil; | |
| UAConfig *config = [UAConfig fromPlistWithContentsOfFile:@"AirshipConfig.plist" error:&error]; | |
| if (error) { | |
| NSLog(@"Airship config failed to initialize based off AirshipConfig.plist: %@", error); | |
| NSLog(@"mParticle will attempt to manually construct UA Config based off your Connection Settings"); | |
| config = [UAConfig config]; | |
| } |
Contributor
There was a problem hiding this comment.
You will get 2 types of errors here:
- If the file does not exist you will get an error. I would imagine you would want to ignore this one for your plugin since some apps will probably rely on mParticle to construct the needed bits.
- Some parsing error, this one you will want to log
How about adding a file exists check before logging those errors?
rlepinski
reviewed
Mar 19, 2025
af77d27 to
87c8378
Compare
rlepinski
reviewed
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)