Draft
Conversation
This reverts commit 3d923d5. Further QA issues have arisen and we aren't able to triage a full solution. Reverting until we cover all cases
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #960 +/- ##
=======================================
Coverage 81.16% 81.17%
=======================================
Files 119 119
Lines 6659 6657 -2
=======================================
- Hits 5405 5404 -1
+ Misses 1254 1253 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
converted back to draft, going to see if we can fold the fixes into #944 this week if not, we can revert and follow-up when the bigger PR is ready |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3d923d5. Further QA issues have arisen and we aren't able to triage a full solution. Reverting until we cover all cases
One-line summary
Significant changes and points to review
Issue / Bugzilla link
new issues to address before this is ready for prod
#959
#946
Testing