Conversation
b333a17 to
31fb40b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #955 +/- ##
==========================================
- Coverage 81.42% 78.56% -2.87%
==========================================
Files 119 121 +2
Lines 6574 6881 +307
==========================================
+ Hits 5353 5406 +53
- Misses 1221 1475 +254 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b00bf89 to
b9a66c5
Compare
b9a66c5 to
6e88cec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line summary
GTM implementation of Google consent mode: https://developers.google.com/tag-platform/security/guides/consent?consentmode=advanced#tag-manager_2
Denial is default. Updates only run with user-driven consent pref (set by marketing opt-out checkbox, consent banner or cookie page)
on
/landing/get, we allow analytics by defaultSignificant changes and points to review
Issue / Bugzilla link
https://mozilla-hub.atlassian.net/browse/WT-602
Testing
When GTM is loaded on most pages:
When GTM is loaded on /landing/get
When user indicates pref, an 'update' dataLayer event appears:
Google verification docs: https://developers.google.com/tag-platform/security/guides/consent-debugging#start-debugging