Skip to content

Conversation

@RinChanNOWWW
Copy link
Contributor

Support for Tencent Cloud Object Storage.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2026

Codecov Report

❌ Patch coverage is 36.00000% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.18%. Comparing base (d9d2eb6) to head (1742fa4).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/cache/cache.rs 0.00% 12 Missing ⚠️
src/cache/cos.rs 0.00% 11 Missing ⚠️
src/config.rs 60.86% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2563   +/-   ##
=======================================
  Coverage   71.18%   71.18%           
=======================================
  Files          64       65    +1     
  Lines       35588    35669   +81     
=======================================
+ Hits        25333    25392   +59     
- Misses      10255    10277   +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

}

// ======= COS =======
let cos = if let Ok(bucket) = env::var("SCCACHE_COS_BUCKET") {
Copy link
Collaborator

@sylvestre sylvestre Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing validation: SCCACHE_COS_ENDPOINT should be required when SCCACHE_COS_BUCKET is set. Add validation like: if env::var('SCCACHE_COS_BUCKET').is_ok() && env::var('SCCACHE_COS_ENDPOINT').is_err() { bail!('SCCACHE_COS_ENDPOINT must be set'); }

Copy link
Contributor Author

@RinChanNOWWW RinChanNOWWW Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the codes of other object stores (like OSS). They don't validate the Option but declare the endpoint as a necessary (must) configuration.

@sylvestre sylvestre merged commit a46b26b into mozilla:main Jan 20, 2026
56 of 57 checks passed
@RinChanNOWWW RinChanNOWWW deleted the cos branch January 20, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants