Skip to content

Conversation

@AJIOB
Copy link
Contributor

@AJIOB AJIOB commented Jan 15, 2026

Fixes #2556

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.08%. Comparing base (82bfa28) to head (24ef01e).

Files with missing lines Patch % Lines
src/compiler/compiler.rs 84.84% 5 Missing ⚠️
src/compiler/gcc.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2557      +/-   ##
==========================================
+ Coverage   71.07%   71.08%   +0.01%     
==========================================
  Files          65       65              
  Lines       35737    35771      +34     
==========================================
+ Hits        25401    25429      +28     
- Misses      10336    10342       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AJIOB AJIOB force-pushed the fix-dist-asm branch 2 times, most recently from e20c1e8 to 1d0e1ae Compare January 16, 2026 09:03
@AJIOB AJIOB force-pushed the fix-dist-asm branch 3 times, most recently from 5ba240e to e2f97cf Compare January 18, 2026 14:20
@AJIOB AJIOB requested a review from sylvestre January 18, 2026 14:26
@ahartmetz
Copy link
Collaborator

Please, like last time: "preprocessor output" or "preprocessed input". Be nice to the people who are going to read what you write.

@AJIOB AJIOB changed the title distributed compilation support for asm & preprocessed outputs distributed compilation support for asm & preprocessor outputs Jan 18, 2026
@AJIOB AJIOB changed the title distributed compilation support for asm & preprocessor outputs Distributed compilation support for asm & preprocessor outputs Jan 18, 2026
@AJIOB
Copy link
Contributor Author

AJIOB commented Jan 18, 2026

Please, like last time: "preprocessor output" or "preprocessed input". Be nice to the people who are going to read what you write.

Oops, thanks again

@AJIOB
Copy link
Contributor Author

AJIOB commented Jan 20, 2026

Hi @sylvestre ,

Is it OK for you?

Looks like I've finalized it

@AJIOB AJIOB force-pushed the fix-dist-asm branch 2 times, most recently from c313b61 to b22c403 Compare January 20, 2026 12:32
@AJIOB AJIOB requested a review from sylvestre January 20, 2026 12:56
@AJIOB
Copy link
Contributor Author

AJIOB commented Jan 23, 2026

@sylvestre , is it OK?

Or you prefer to manually list all possible enum values twice?

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 23, 2026

Merging this PR will degrade performance by 5.28%

❌ 1 regressed benchmark
✅ 53 untouched benchmarks
⏩ 2 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation time_macro_finder_chunked 971.9 µs 1,026.1 µs -5.28%

Comparing AJIOB:fix-dist-asm (24ef01e) with main (82bfa28)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@AJIOB
Copy link
Contributor Author

AJIOB commented Jan 23, 2026

Benchmark degrading is similar to another PRs, such as in #2521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

assembly support broken

4 participants