Regexp performance regression fixes. #2233
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! This is great and I will take a look -- but I also think that we should go ahead and publish 1.9.0 without it, since I think we're in a good place, and have lots of other big changes coming. Let me know if you think differently! |
Contributor
Author
|
I'll let @balajirrao create a new PR for this since he has done the work to get these changes organised into meaningful commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gbrail here is the stuff @balajirrao and I had worked on a while ago, but never made it to a PR due to other commitments. I believe this should resolve almost all of the regression mentioned in #2227. The main idea is to take a fairly optimised approach for the common cases, while still being able to take a slower approach where needed for spec compliance.