Intl402 #2203
Intl402 #2203
Conversation
|
Well the new test262 framework works, and that's pretty cool. Let me take some time to read it more carefully (I'd be happy if someone else does too) and make sure it still supports the old use cases! |
|
I'll try and take a look at this tomorrow. |
|
I think this is good and I appreciate the forward progress. Interested if anyone else wants to look, otherwise I'm happy with it! |
|
I think it looks good, I've got some changes to run 262 cases in debug mode which would need some to rebase but it doesn't look too bad. |
| assertWithAllModes402("\u221e", "Infinity.toLocaleString('ar-SA')"); | ||
| } | ||
|
|
||
| private void assertWithAllModes402(final Object expected, final String script) { |
There was a problem hiding this comment.
Should these two go in Utils?
What do you mean? It already takes well over two minutes for me, so "much slower" is really worrying 😅 |
⌛
|
|
Yeah, seems fine to me locally, even after enabling the debugger tests. |
The current impl has some problem and I was not able to fix that in the existing code. Therefore I wrote a new one. Problems are mainly occure when enabling the intl402 test; different from the other test this part has test files at the folder root also. The stats for exluded folders now always available and the order of excluded folders is a bit more natural. The new version is much slower but i think this is not a real problem with this suite.
* if 402 is not enabled for the context, ignore the given parameters * if 402 is enabled, support string locales
|
Thanks! I've had a chance to look at this and try it and it looks good. I'm not going to "squash" it because it touches a few different things -- it probably would have been a good idea to separate the Test262 rewrite with the other changes, but I'm good. Thanks! |
4 participants
This enables the intl402 test for the 262 test suite and also provides a first fix for #535
This is based on a rewritten test262.properties generator because the current impl has some problem and I was not able to fix that in the existing code. Problems are mainly occure when enabling the intl402 test; different from the other test this part has test files at the folder root also. The stats for exluded folders now always available and the order of excluded folders is a bit more natural.
The new version is much slower but i think this is not a real problem with this suite.
Not so many intl402 tests are passing so far but this is a beginning (hopefully)