Skip to content

Release note remove app - #17241

Merged
wen-2018 merged 3 commits into
mainfrom
release-note-remove-app
Jun 23, 2026
Merged

Release note remove app#17241
wen-2018 merged 3 commits into
mainfrom
release-note-remove-app

Conversation

@wen-2018

Copy link
Copy Markdown
Collaborator

If this changeset needs to go into the FXC codebase, please add the WMO and FXC label.

One-line summary

This PR can only be merged after #17240 is deployed.

Significant changes and points to review

  • removes release notes app entirely after DB clean up is complete.

Issue / Bugzilla link

#17225 (comment)

Testing

@janriokrause janriokrause left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with some minor improvements:

  1. After rebasing and the previous PR has landed, please do not forget to git rm bedrock/releasenotes/migrations/0003_delete_productrelease.py.

  2. Remove releasenotes.ProductRelease \ from the dumpdata call in bin/export-db-to-sqlite.sh (line 196). It will break the export otherwise.

  3. Fix the stale # For release notes. comment on "www.mozilla.org" in _csp_img_src in bedrock/settings/__init__.py, or drop the entry if nothing else needs it. Probably @stevejalim knows best.

  4. Follow-up PR after this one merges: Remove django-memoize==2.3.1 from requirements/prod.in, then regenerate prod.txt + dev.txt.

@wen-2018
wen-2018 force-pushed the release-note-remove-app branch from 68d3aea to 9e80c9e Compare June 19, 2026 16:11
Comment thread bedrock/settings/__init__.py Outdated
@wen-2018
wen-2018 force-pushed the release-note-remove-app branch from 9ac1112 to 8326026 Compare June 22, 2026 15:28
@wen-2018
wen-2018 marked this pull request as ready for review June 22, 2026 15:28
@wen-2018
wen-2018 requested a review from a team as a code owner June 22, 2026 15:28
@wen-2018
wen-2018 requested a review from janriokrause June 22, 2026 15:30
@wen-2018

Copy link
Copy Markdown
Collaborator Author

Remove releasenotes.ProductRelease \ from the dumpdata call in bin/export-db-to-sqlite.sh (line 196). It will break the export otherwise.

This had been addressed in #17250

@janriokrause janriokrause left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ Thank you!

@janriokrause

Copy link
Copy Markdown
Contributor

Two quick follow-up notes:

  1. django-memoize: already unused. The only memoize in the codebase is a local decorator in lib/l10n_utils/fluent.py, nothing imports from the django-memoize package, so dropping it from requirements/prod.in and regenerating prod.txt + dev.txt is safe to do whenever. (as mentioned above)

  2. whatsnew-fx146-donate.html is dead code: WNP_145_PLUS_RE in bedrock/firefox/redirects.py unconditionally 301s /firefox/146.0/whatsnew/ to www.firefox.com, so the template is unreachable. Safe to remove along with:

    • firefox/whatsnew/whatsnew-fx146-donate.html entry in WhatsnewView.ftl_files_map (bedrock/firefox/views.py)
    • firefox_whatsnew_146_donate CSS bundle declaration
    • /media/img/firefox/whatsnew/whatsnew146/ image assets
    • whatsnew-donate-* Fluent strings in l10n/en/firefox/whatsnew/whatsnew.ftl if nothing else references them

Both are unrelated to the release-notes-app removal, so I'd keep them out of this PR and bundle them into two follow-ups. Feel free to pick it up or let me know if you don't have headspace.

@wen-2018
wen-2018 merged commit db65e4d into main Jun 23, 2026
6 checks passed
@wen-2018
wen-2018 deleted the release-note-remove-app branch June 23, 2026 13:50
@wen-2018 wen-2018 mentioned this pull request Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants