Release note remove app - #17241
Conversation
janriokrause
left a comment
There was a problem hiding this comment.
Looks good with some minor improvements:
-
After rebasing and the previous PR has landed, please do not forget to
git rm bedrock/releasenotes/migrations/0003_delete_productrelease.py. -
Remove
releasenotes.ProductRelease \from thedumpdatacall inbin/export-db-to-sqlite.sh(line 196). It will break the export otherwise. -
Fix the stale
# For release notes.comment on"www.mozilla.org"in_csp_img_srcinbedrock/settings/__init__.py, or drop the entry if nothing else needs it. Probably @stevejalim knows best. -
Follow-up PR after this one merges: Remove
django-memoize==2.3.1fromrequirements/prod.in, then regenerateprod.txt+dev.txt.
68d3aea to
9e80c9e
Compare
Co-authored-by: Steve Jalim <stevejalim@mozilla.com>
9ac1112 to
8326026
Compare
This had been addressed in #17250 |
|
Two quick follow-up notes:
Both are unrelated to the release-notes-app removal, so I'd keep them out of this PR and bundle them into two follow-ups. Feel free to pick it up or let me know if you don't have headspace. |
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.One-line summary
This PR can only be merged after #17240 is deployed.
Significant changes and points to review
Issue / Bugzilla link
#17225 (comment)
Testing