-
Notifications
You must be signed in to change notification settings - Fork 956
Anonym Part 6: Static Pages #16967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anonym Part 6: Static Pages #16967
Conversation
…lements on AnonymTopAndBottomPage
… better handle the need for other card types in the future
…setting verbose_name
…tting verbose_name
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## WT-514-anonym-homepage-cms #16967 +/- ##
=============================================================
Coverage ? 80.79%
=============================================================
Files ? 164
Lines ? 9384
Branches ? 0
=============================================================
Hits ? 7582
Misses ? 1802
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kkellydesign
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets merge and revise in a new PR – notes here: https://mozilla-hub.atlassian.net/browse/WT-561
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.This pull request depends on #16965
One-line summary
This pull request makes it possible to create the 'News' and 'Contact' Anonym pages.
Significant changes and points to review
AnonymStaticPagethat gets subclassed inAnonymNewsPageandAnonymContactPage. Having the pages live in Wagtail (even though they are not editable in Wagtail) allows adding/removing them in the navigation without code changesIssue / Bugzilla link
Testing
Note: this pull request does NOT include the styles needed to match the designs