Skip to content

Bug 2009482: [ci full] Add eval-jexl support for Android nimbus-cli #7163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yashikakhurana wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bug 2009482: [ci full] Add eval-jexl support for Android nimbus-cli #7163

yashikakhurana wants to merge 3 commits into from
+38 −11

Conversation

@yashikakhurana
Copy link
Contributor

@yashikakhurana yashikakhurana commented Jan 15, 2026 •
edited
Loading

Summary

This PR adds Android support for the nimbus-cli eval-jexl command to evaluate JEXL targeting expressions against the app context on Android devices and emulators.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@yashikakhurana
Bug 2009482: Add eval-jexl support for Android
2057c48 
- Added evalJexl field to CliArgs data class
- Added EVAL_JEXL_KEY constant
- Added JEXL evaluation logic using NimbusMessagingHelper.evalJexl()
- Added --eval-jexl parameter parsing in both intent and URI-based args
- Logs results as JSON with JEXL_RESULT prefix for CLI capture

This completes eval-jexl support for Android to work with nimbus-cli.
@yashikakhurana yashikakhurana marked this pull request as draft January 15, 2026 18:57
@yashikakhurana
Fix ArgumentProcessorTest to include evalJexl parameter
4db635e 
All CliArgs constructor calls in tests now include the evalJexl parameter (null for existing tests).

This fixes compilation errors where the CliArgs data class signature changed to include evalJexl.
@yashikakhurana
Fix detekt TooGenericExceptionCaught lint error
ba442bc 
Add @Suppress annotation for catching Exception in evalJexl handler.
We need to catch all exceptions to return any JEXL evaluation error
as a JSON result for the CLI to capture.
@yashikakhurana yashikakhurana marked this pull request as ready for review January 16, 2026 18:07
@yashikakhurana yashikakhurana changed the title Bug 2009482: Add eval-jexl support for Android nimbus-cli Bug 2009482: [ci full] Add eval-jexl support for Android nimbus-cli Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freshstrangemusic freshstrangemusic Awaiting requested review from freshstrangemusic

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yashikakhurana