Skip to content

Move login breach fields into meta record #7155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Move login breach fields into meta record #7155

jo wants to merge 2 commits into from
+416 −60

Conversation

@jo
Copy link
Contributor

@jo jo commented Jan 12, 2026 •
edited
Loading

Move the previously introduced login breach-related fields time_of_last_breach and time_last_breach_alert_dismissed from LoginFields into LoginMeta struct, to group internally handled fields which are not directly updateable.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@jo jo force-pushed the breach-alert-meta branch 2 times, most recently from 538a55d to 84e9791 Compare January 15, 2026 09:02
jo added 2 commits January 16, 2026 14:37
@jo
Move login breach fields into meta record
c059a4b 
Move the previously introduced login breach-related fields
`time_of_last_breach` and `time_last_breach_alert_dismissed` from
LoginFields into LoginMeta struct, to group internally handled fields
which are not directly updateable.
@jo
Add password reuse detection for breach alerts
b3f4083 
Add breachesL table (schema v4) to track breached passwords and enable
cross-domain password reuse detection. New APIs:
get_potentially_vulnerable_passwords() and is_potentially_vulnerable_password().
@jo jo force-pushed the breach-alert-meta branch from 84e9791 to b3f4083 Compare January 16, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jo