Open
Conversation
(we were missing the "capture" feature) and switch back to sentry's now longstanding default transport of reqwest+rustls, which avoids issues w/ our grpc client's included boringssl that occurred w/ reqwest+native-tls Closes STOR-493
taddes
approved these changes
Mar 27, 2026
Collaborator
taddes
left a comment
taddes
left a comment
There was a problem hiding this comment.
lgtm, though I'll have to get brief context on this from you sometime. grpcio ftw. Is this basically where reqwest and grpcio's boringssl fight over TLS internals, so libcurl was used as a side-step since it has its own independent TLS stack that didn't clash?
chenba
reviewed
Mar 27, 2026
| // likely grpcio's boringssl | ||
| let curl_transport_factory = |options: &sentry::ClientOptions| { | ||
| Arc::new(sentry::transports::CurlHttpTransport::new(options)) as Arc<dyn sentry::Transport> | ||
| }; |
Collaborator
There was a problem hiding this comment.
What changed so we no longer need this? Sorry I don't have the context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(we were missing the "capture" feature)
and switch back to sentry's now longstanding default transport of reqwest+rustls, which avoids issues w/ our grpc client's included boringssl that occurred w/ reqwest+native-tls
Issue(s)
Closes STOR-493