Use jsonschema-transpiler's pinned dependencies on install#792
Open
badboy wants to merge 1 commit intomozilla-services:mainfrom
Open
Use jsonschema-transpiler's pinned dependencies on install#792badboy wants to merge 1 commit intomozilla-services:mainfrom
badboy wants to merge 1 commit intomozilla-services:mainfrom
Conversation
See https://doc.rust-lang.org/cargo/commands/cargo-install.html#dealing-with-the-lockfile `--locked` will use the bundled Cargo.lock file with pinned dependencies, instead of recalculating dependency versions. This allows reproducible builds and avoids issues when any dependency releases a new version that contains incompatible changes.
akkomar
approved these changes
Oct 31, 2023
relud
approved these changes
Oct 31, 2023
Contributor
Author
|
I don't have merge rights here. @akkomar can you land it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://doc.rust-lang.org/cargo/commands/cargo-install.html#dealing-with-the-lockfile
--lockedwill use the bundled Cargo.lock file with pinned dependencies, instead of recalculating dependency versions. This allows reproducible builds and avoids issues when any dependency releases a new version that contains incompatible changes.cc @relud
Checklist for reviewer:
./.github/push-to-trigger-integration <username>:<branchname>For glean changes:
templates/include/glean/CHANGELOG.mdFor modifications to schemas in restricted namespaces (see
CODEOWNERS):