Skip to content

DISCO-3960 Add AI policy#1350

Open
gruberb wants to merge 4 commits intomainfrom
DISCO-3960-ai-policy
Open

DISCO-3960 Add AI policy#1350
gruberb wants to merge 4 commits intomainfrom
DISCO-3960-ai-policy

Conversation

@gruberb
Copy link
Copy Markdown
Member

@gruberb gruberb commented Mar 26, 2026

References

JIRA: DISCO-3960

Description

Adding an AI policy to the Merino codebase. The following text is the result of an internal document + discussion around that topic.

PR Review Checklist

Put an x in the boxes that apply

  • This PR conforms to the Contribution Guidelines
  • The PR title starts with the JIRA issue reference, format example [DISCO-####], and has the same title (if applicable)
  • [load test: (abort|skip|warn)] keywords are applied to the last commit message (if applicable)
  • Documentation has been updated (if applicable)
  • Functional and performance test coverage has been expanded and maintained (if applicable)

┆Issue is synchronized with this Jira Task

@gruberb gruberb requested a review from a team March 26, 2026 15:23
Copy link
Copy Markdown
Contributor

@ncloudioj ncloudioj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Added some comments for broader discussion.

@gruberb gruberb requested a review from ncloudioj March 27, 2026 16:56
Copy link
Copy Markdown
Collaborator

@mmiermans mmiermans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the initiative to write up an AI policy. There are some great principles in here, and things I would remove or rephrase. I'd be happy to discuss these live if that's helpful.

*should* do. All tests must be understood by the submitter and must conform to Merino's
[testing guidelines](CONTRIBUTING.md#testing-guidelines--best-practices).

### Keep changes small and intentional
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this section, because I don't think it is specific to AI. We agreed to 'Aim for Simplicity' in our social-contract.md, and those rules apply also to code written by AI. PRs should be small and intentional, regardless of whether AI was involved.

Large changes may be screened for AI generation. Not to police tool use, but to ensure that the scope of a contribution reflects genuine understanding and effort.

PRs should be reviewed on their merit; if a PR is too large, then the reviewer and contributor can decide to split it up. Over the years I have fallen in the pitfall of blowing up scope many times. With AI, it becomes much easier to split PRs up.

Comment on lines +43 to +48
## Risk Awareness

Depending on tools that make large changes without understanding them introduces risk.

The major AI coding tools are proprietary. Reliance on their availability is
not in the interest of an open-source project. Slowing down and knowing exactly what we need to ship can have a bigger impact than optimizing for speed and volume.
Copy link
Copy Markdown
Collaborator

@mmiermans mmiermans Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this section. The risk perspective is interesting, but speculative and debatable in my view. I would love to hear more; the 'Claude show & tell' series may be a good venue for this.

When to slow down and when to move with urgency is a question that predates AI. In my view it's best left up to individual teams to find the right balance here.

Comment on lines +29 to +31
Documentation exists to transfer knowledge and to reveal your own understanding gaps.

AI-generated text that has not been fully rewritten by a human is easily identifiable and will not be accepted. If AI was used to assist in drafting documentation, it must be disclosed. Using AI to *study* the codebase and inform your writing is fine; submitting AI-generated prose as your own is not.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we agree that documentation should meet a real developer need, and that the contributor should understand and stand behind it. I would soften this section. The important question is less how the text was produced, and more whether it is accurate and useful. I think that standard can also be met when a developer uses AI responsibly.

Suggested change
Documentation exists to transfer knowledge and to reveal your own understanding gaps.
AI-generated text that has not been fully rewritten by a human is easily identifiable and will not be accepted. If AI was used to assist in drafting documentation, it must be disclosed. Using AI to *study* the codebase and inform your writing is fine; submitting AI-generated prose as your own is not.
Documentation exists to transfer knowledge and to serve the humans
who need to read and maintain this project. It should be accurate,
specific, and grounded in the contributor's understanding of the code
and the problem space.
Contributors are expected to understand the documentation they submit,
to be able to explain and defend it during review, and to take
ownership of keeping it aligned with the code over time.

^ As an example of responsible AI use, this suggestion was generated with AI. It was guided by my viewpoint, and I iterated on it until it reflected what I wanted to say. I think that kind of use should be welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants