Fix #25645 - RTL layout issues in URLBar#31851
Open
MarkKirichko2002 wants to merge 1 commit intomozilla-mobile:mainfrom
Open
Fix #25645 - RTL layout issues in URLBar#31851MarkKirichko2002 wants to merge 1 commit intomozilla-mobile:mainfrom
MarkKirichko2002 wants to merge 1 commit intomozilla-mobile:mainfrom
Conversation
Use directional trailing anchor for stopReloadButton instead of conflicting leading/trailing constraints to urlBarBorderView. This ensures proper positioning in RTL languages (Arabic, Hebrew) without overlapping the URL text field, while preserving LTR behavior.
thatswinnie
requested review from
razvanlitianu and
thatswinnie
and removed request for
thatswinnie
Collaborator
|
hi @MarkKirichko2002. Thanks for the PR. One small request can you adjust the x padding to match the left to right languages? |
Contributor
|
There are probably tricks for that, how reasonably could the "‹" chevron be flipped to point "›" opposite direction which would be probably more desirable as "back" affordance for RTL UIs? |
Contributor
|
Ah yeah, before there were |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed incorrect RTL rendering of URLBar elements: overlapping and mispositioned components in right-to-left languages (Arabic, Hebrew, etc.).
Changes:
trailing.equalToSuperview().inset(...)instead of conflicting leading/trailing tourlBarBorderViewAddresses the core issue of overlapping urlbar elements in RTL as reported in #25645.
Fixes #25645