Skip to content

Bug 2024167 - Added haptic feedback on summary in s2s #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fmasalha wants to merge 1 commit into from
+10 −0
Closed

Bug 2024167 - Added haptic feedback on summary in s2s #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...ature/summarize/src/main/java/mozilla/components/feature/summarize/SummarizationScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.hapticfeedback.HapticFeedbackType
import androidx.compose.ui.input.nestedscroll.nestedScroll
import androidx.compose.ui.platform.LocalHapticFeedback
import androidx.compose.ui.platform.rememberNestedScrollInteropConnection
import androidx.compose.ui.tooling.preview.PreviewParameter
import androidx.compose.ui.tooling.preview.PreviewParameterProvider
Expand Down Expand Up @@ -86,8 +88,16 @@ private fun SummarizationScreen(
store: SummarizationStore,
settingsStore: SummarizeSettingsStore? = null,
) {
val haptic = LocalHapticFeedback.current

val state by store.stateFlow.collectAsStateWithLifecycle()

LaunchedEffect(state) {
if (state is SummarizationState.Summarized) {
haptic.performHapticFeedback(HapticFeedbackType.Confirm)
}
}

SummarizationScreenScaffold(
modifier = modifier
.thenConditional(Modifier.summaryLoadingGradient()) {
Expand Down