Skip to content

Conversation

@faceless2
Copy link

Re issue #147, the basic requirement in any authentication scheme is knowing the username specified during the CONNECT phase. So I think this really should be in the core API, rather than added by users.

This patch adds a that as the Client.username property.

@robertsLando
Copy link
Member

You should add a unit test that covers this

@robertsLando
Copy link
Member

I would also know @getlarge and @mcollina thoughts on this

@getlarge
Copy link
Member

It makes sense to have the username by default in the client, personally i always add it manually :)
And yes some tests would be needed and the types should be updated too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants