Fix flaky test_unwanted_testsuite_name on Windows#1291
Open
brianegge wants to merge 1 commit intomorganstanley:mainfrom
Open
Fix flaky test_unwanted_testsuite_name on Windows#1291brianegge wants to merge 1 commit intomorganstanley:mainfrom
brianegge wants to merge 1 commit intomorganstanley:mainfrom
Conversation
The test asserted exactly 1 UserWarning, but on Windows the long suite
name (256 chars) triggers additional warnings during plan execution,
resulting in 5 warnings total. Changed assertion to verify at least one
warning contains the expected message ("too long" or "colon") instead
of checking the exact count.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_unwanted_testsuite_namewith a 256-char suite name fails consistently on Windows (Python 3.10) becauseassert len(record) == 1expects exactly 1UserWarning, but on Windows the long name triggers 4 additional warnings during plan execution, totaling 5"too long"or"colon") instead of checking the exact countTest plan
Test (windows-latest, 3.10, [all])passes in CI🤖 Generated with Claude Code