Fix flaky driver timing assertions in test_base#1287
Open
brianegge wants to merge 1 commit intomorganstanley:mainfrom
Open
Fix flaky driver timing assertions in test_base#1287brianegge wants to merge 1 commit intomorganstanley:mainfrom
brianegge wants to merge 1 commit intomorganstanley:mainfrom
Conversation
The upper bounds on driver setup/teardown duration assertions were too tight (0.2-0.3s), causing intermittent failures on slow CI runners (especially Windows). Widened to 1.0s which still validates reasonable timing while accommodating CI variability. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
brianegge
force-pushed
the
fix-flaky-driver-timing-test
branch
from
4a27826 to
44d56b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code