[fix]: support Notion uploaded video/audio playback and fix heading background color width#439
Open
amaran-th wants to merge 3 commits intomorethanmin:mainfrom
Open
Conversation
|
Someone is attempting to deploy a commit to the untilled Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1. Notion uploaded video/audio playback (closes #405)
notion-client'saddSignedUrlsskipsattachment:uuid:filenameformat URLs, which Notion uses for directly uploaded files. As a result, the browser receives an unsigned URL it cannot load./api/notion-fileproxy route that callsgetSignedFileUrlson each request to get a fresh signed URLgetRecordMap, for video/audio blocks withattachment:source URLs that were skipped bynotion-client, the proxy URL is injected intosigned_urlsso react-notion-x can render them correctly2. Heading block background color spans full width (closes #412)
react-notion-x applies
display: inline-blockto.notion-h, and the parent container usesalign-items: flex-start, causing heading elements to only stretch to text width. Block background colors appeared clipped to the text area.display: block; width: 100%on.notion-h3. ProfileCard text center alignment (closes #161)
Multi-line text in the ProfileCard was not centering properly on desktop.
text-align: centerto the card's flex column containerRelated tickets
#161
#405
#412
PR Checklist