[WIP] Update the version of Xcode from 9.2.0 to 10.1.0#6
Open
lyuich wants to merge 6 commits intomonstar-lab:masterfrom
Open
[WIP] Update the version of Xcode from 9.2.0 to 10.1.0#6lyuich wants to merge 6 commits intomonstar-lab:masterfrom
lyuich wants to merge 6 commits intomonstar-lab:masterfrom
Conversation
Generated by 🚫 Danger |
Contributor
Author
|
Notes: 1. The webhook of CircleCI didn't work on push eventsThis problem was fixed according to the following steps.
Then, the trigger worked after pushing only the hash change using
2. GitHub Access Token for Danger was missing on CircleCIThe problem was solved by setting the CircleCI - Jobs monstar-lab/sample-ios-swift pull/6 74 (build) 3.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
IDEWorkspaceChecks.plistto the repository which is generated after Xcode 9.3Motivation and Context
Build failed on CircleCI because the latest
swiftlintrequires Xcode 10.0 to be installed.So, I updated Xcode (local and CircleCI) and Carthage (RxSwift).
Description
IDEWorkspaceChecks.plistswiftlintrequires Xcode 10.0 or laterScreenshot
swiftlintrequires Xcode 10.0 to be installed.Reference