DRIVERS-2924 test accessToken form of KMS providers#1914
Open
kevinAlbs wants to merge 10 commits intomongodb:masterfrom
Open
DRIVERS-2924 test accessToken form of KMS providers#1914kevinAlbs wants to merge 10 commits intomongodb:masterfrom
accessToken form of KMS providers#1914kevinAlbs wants to merge 10 commits intomongodb:masterfrom
Conversation
eramongodb
requested changes
Mar 19, 2026
`oneOf` better fits the intent. `oneOf` means "exactly" one. Use `required` to prevent an empty document from matching both choices.
eramongodb
approved these changes
Mar 19, 2026
alcaeus
reviewed
Mar 23, 2026
Member
alcaeus
left a comment
There was a problem hiding this comment.
Changes themselves LGTM. You should add schema tests (see the tests/valid and tests/invalid directories) to ensure correct behaviour of anyOf and allOf.
Contributor
Author
AFAICT I cannot specifically test the change of However, I added |
alcaeus
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test
accessTokenform of KMS providersBackground & Motivation
See DRIVERS-2924. The Azure and GCP KMS providers support specifying an
accessTokenwithin libmongocrypt. Though theaccessTokenform is specified, there were no specification tests prior to this PR.Schema 1.28 is a copy of 1.27 with the
accessTokenform of KMS providers added. The copy and addition are on separate commits to ease review. Caveat: schema 1.28 is only added to supportaccessToken. I briefly considered prose tests, but I expect that is more manual changes for driver teams. Updating the unified test runner to support theaccessTokenfield was a small effort in the C driver.DOCSP-58569 was filed to document the
accessTokenform of KMS providers in the mongodb.com docs.Running tests
The new spec tests include KMS provider configuration using the
$$placeholdervalue:mongodb-labs/drivers-evergreen-tools#751 generates access tokens to test. Spec tests were tested in the C driver: mongodb/mongo-c-driver#2253
Please complete the following before merging:
accessTokenKMS providers mongo-c-driver#2253)clusters). (CDRIVER-6270 test and document
accessTokenKMS providers mongo-c-driver#2253)