[LG-844] feat(collection-toolbar): CollectionToolbar Title SubComponent#3420
Merged
adamrasheed merged 10 commits intoar/LG-5830-collection-toolbarfrom Jan 7, 2026
Merged
Conversation
|
Contributor
|
Size Change: +1.87 kB (+0.1%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
adamrasheed
changed the title
adamrasheed
force-pushed
the
ar/LG-5844-collection-toolbar-title
branch
from
44bcebd to
9279070
Compare
adamrasheed
changed the title
adamrasheed
requested review from
stephl3 and
tsck
and removed request for
a team
stephl3
reviewed
Dec 30, 2025
packages/collection-toolbar/src/CollectionToolbar/CollectionToolbar.types.ts
Outdated
Show resolved
Hide resolved
packages/collection-toolbar/src/CollectionToolbar/CollectionToolbar.tsx
Outdated
Show resolved
Hide resolved
packages/collection-toolbar/src/CollectionToolbar/CollectionToolbar.tsx
Outdated
Show resolved
Hide resolved
...s/collection-toolbar/src/CollectionToolbar/CollectionToolbarTitle/CollectionToolbarTitle.tsx
Outdated
Show resolved
Hide resolved
...lection-toolbar/src/CollectionToolbar/CollectionToolbarTitle/CollectionToolbarTitle.types.ts
Outdated
Show resolved
Hide resolved
...lection-toolbar/src/CollectionToolbar/CollectionToolbarTitle/CollectionToolbarTitle.types.ts
Outdated
Show resolved
Hide resolved
...lection-toolbar/src/CollectionToolbar/CollectionToolbarTitle/CollectionToolbarTitle.spec.tsx
Outdated
Show resolved
Hide resolved
...lection-toolbar/src/CollectionToolbar/CollectionToolbarTitle/CollectionToolbarTitle.spec.tsx
Outdated
Show resolved
Hide resolved
stephl3
reviewed
Dec 30, 2025
Collaborator
stephl3
left a comment
stephl3
left a comment
There was a problem hiding this comment.
Can you update the README as you implement different pieces to colocate docs and related code in the same PRs?
packages/collection-toolbar/src/CollectionToolbar/CollectionToolbar.types.ts
Show resolved
Hide resolved
packages/collection-toolbar/src/CollectionToolbar/CollectionToolbar.tsx
Outdated
Show resolved
Hide resolved
| import { getCollectionToolbarStyles } from './CollectionToolbar.styles'; | ||
| import { CollectionToolbarProps } from './CollectionToolbar.types'; | ||
|
|
||
| export const CollectionToolbar = CompoundComponent( |
Collaborator
There was a problem hiding this comment.
Do we want to include a forwardRef for this component?
Collaborator
There was a problem hiding this comment.
This is wrapped in forwardRef now, but we're still missing a ref being passed to the root <div>
packages/collection-toolbar/src/CollectionToolbar/CollectionToolbar.tsx
Outdated
Show resolved
Hide resolved
packages/collection-toolbar/src/CollectionToolbar/CollectionToolbar.types.ts
Outdated
Show resolved
Hide resolved
adamrasheed
changed the title
stephl3
approved these changes
Jan 6, 2026
Collaborator
stephl3
left a comment
stephl3
left a comment
There was a problem hiding this comment.
just the missing ref forwarding but overall LGTM
| import { getCollectionToolbarStyles } from './CollectionToolbar.styles'; | ||
| import { CollectionToolbarProps } from './CollectionToolbar.types'; | ||
|
|
||
| export const CollectionToolbar = CompoundComponent( |
Collaborator
There was a problem hiding this comment.
This is wrapped in forwardRef now, but we're still missing a ref being passed to the root <div>
Contributor
|
Coverage after merging ar/LG-5844-collection-toolbar-title into ar/LG-5830-collection-toolbar will be
Coverage Report for Changed Files
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
adamrasheed
added a commit
that referenced
this pull request
Jan 7, 2026
…nt (#3420) * [LG-844] feat(collection-toolbar): Title component * updated lintin * updated tests, linitng cleanup * feedback updates * fixed type exports * updated collectionToolbar ref, updated added types docs * added context provider * fixed storybook darkmode, updated defaul theading element * reverted heading * added refs
adamrasheed
added a commit
that referenced
this pull request
Jan 7, 2026
…nt (#3420) * [LG-844] feat(collection-toolbar): Title component * updated lintin * updated tests, linitng cleanup * feedback updates * fixed type exports * updated collectionToolbar ref, updated added types docs * added context provider * fixed storybook darkmode, updated defaul theading element * reverted heading * added refs
adamrasheed
added a commit
that referenced
this pull request
Jan 9, 2026
…nt (#3420) * [LG-844] feat(collection-toolbar): Title component * updated lintin * updated tests, linitng cleanup * feedback updates * fixed type exports * updated collectionToolbar ref, updated added types docs * added context provider * fixed storybook darkmode, updated defaul theading element * reverted heading * added refs
adamrasheed
added a commit
that referenced
this pull request
Jan 9, 2026
…nt (#3420) * [LG-844] feat(collection-toolbar): Title component * updated lintin * updated tests, linitng cleanup * feedback updates * fixed type exports * updated collectionToolbar ref, updated added types docs * added context provider * fixed storybook darkmode, updated defaul theading element * reverted heading * added refs
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
* [LG-5830] feat(collection-toolbar): Collection Toolbar component * fixed linting, updated story, updated tests, udpated imports * [LG-844] feat(collection-toolbar): CollectionToolbar Title SubComponent (#3420) * [LG-844] feat(collection-toolbar): Title component * updated lintin * updated tests, linitng cleanup * feedback updates * fixed type exports * updated collectionToolbar ref, updated added types docs * added context provider * fixed storybook darkmode, updated defaul theading element * reverted heading * added refs * [LG-5840] feat(collection-toolbar): add Actions compound component with Button, Menu, MenuItem, and Pagination (#3432) * [LG-844] feat(collection-toolbar): Title component * updated lintin * updated tests, linitng cleanup * feedback updates * added context provider * fixed storybook darkmode, updated defaul theading element * [LG-5840] feat(collection-toolbar): Collection toolbar actions + Button * updates * adding pagination * added menu, menuitem, pagination, added unit tests * rm vscode settings * linting fix, updated tests * updated test * cleanup * moved to named exports, made toggleButton optional * updated provider logic, added unit test * updated for r17 * test cleanup * tests cleanup * updated title test, updated button types * updated menuProps * cleanup * [LG-5838] feat(collection-toolbar): SearchInput Component (#3469) * [LG-5838] feat(collection-toolbar): SearchInput Component * revert vscode settings * linting * cleanup * updated title styles * updated styles, cleanup * cleaned up prop types * added ally package * style cleanup, rc17 fix * linting * [LG-5841] feat(collection-toolbar): Filters and Subcomponents (#3477) * [LG-5838] feat(collection-toolbar): SearchInput Component * revert vscode settings * linting * cleanup * updated title styles * updated styles, cleanup * [LG-5841] feat(collection-toolbar): Filters and Subcomponents * [LG-5841] feat(collection-toolbar): Filters and Subcomponents * cleanup * added root styles, added segmentcontrol, select, and option * linting * added filter widths, cleanup * cleaned up stories, added unit test, styling updates * updated test, cleanedup label props * updated styling colocation, cleaned up exports, organized types * cleaned up searchinput types, udpated exports * cleanup * updated a11y types, fixed exports * cleaned up searchInput * fix tests * r17 fix, cleanup * Added comboboxoption, added missing exports, lgid cleanup * select cleanup * ref cleanup * exported ComboBoxOptionProps * updated filters styles, revert select * updated types, rm extra className, rename SelectOption * r17 fix * Added changeset * [LG-5937] feat(collection-toolbar): Refactor Compound Components (#3489) * [LG-5838] feat(collection-toolbar): SearchInput Component * revert vscode settings * linting * cleanup * updated title styles * updated styles, cleanup * [LG-5841] feat(collection-toolbar): Filters and Subcomponents * [LG-5841] feat(collection-toolbar): Filters and Subcomponents * cleanup * added root styles, added segmentcontrol, select, and option * linting * added filter widths, cleanup * cleaned up stories, added unit test, styling updates * updated test, cleanedup label props * updated styling colocation, cleaned up exports, organized types * cleaned up searchinput types, udpated exports * cleanup * updated a11y types, fixed exports * cleaned up searchInput * fix tests * r17 fix, cleanup * Added comboboxoption, added missing exports, lgid cleanup * select cleanup * ref cleanup * exported ComboBoxOptionProps * updated filters styles, revert select * updated types, rm extra className, rename SelectOption * r17 fix * [LG-5937] feat(collection-toolbar): Refactor Compound Components * added changeset * rm changeset * cleanup * fixed tests, update selectOption displayName * exported menuItemClassName, added children validation * renamed pt1 * renamed ComboboxOption pt2 * rename pt3 * rename pt4 * cleanup * cleanup * more cleanup * [LG-5845] feat(collection-toolbar): Compact & Collapsible Variant Styling (#3497) * [LG-5845] feat(collection-toolbar): Variant Styling * added terst * tests cleanup * updated render logic, a11y improvements, animation styling improvements * updated stories, updated mobile styles * updated stories formatting * updated styles * updated changeset * updated changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR introduces the
CollectionToolbar.Titlecompound subcomponent for theCollectionToolbarpackage.This component:
CompoundComponentandCompoundSubComponentutilities) to integrate with the parentCollectionToolbarH3typography element for the title content, while allowing the user to change the elment via anaspropCollectionToolbarvariant is set toCollapsibleSizeandVariantenums for better component API ergonomicsAdditionally, this PR improves the Storybook configuration with proper
StoryMetaType, argument types, and aLiveExamplestory that demonstrates the title component usage.🎟️ Jira ticket: LG-5844
NOTE: The
CollectionToolbarProviderwhich controls the darkmode value for the Title will be added in a future PR✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
pnpm storybookand navigate to Components / CollectionToolbarCollectionToolbar.Titlein actionvariantcontrol toCollapsible- the title should appearvariantcontrol toDefault- the title should be hiddensizeanddarkModecombinations