wallet: unrestrict get_transfers and get_transfer_by_txid#10271
Open
jeffro256 wants to merge 1 commit intomonero-project:masterfrom
Open
wallet: unrestrict get_transfers and get_transfer_by_txid#10271jeffro256 wants to merge 1 commit intomonero-project:masterfrom
get_transfers and get_transfer_by_txid#10271jeffro256 wants to merge 1 commit intomonero-project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow calling wallet RPC endpoints
get_transfersandget_transfer_by_txideven with--restricted-rpcenabled. These two endpoints, after these changes, do not modify wallet state at all. The pool information may be outdated in restricted mode, though. This API change is breaking is the sense that some people may have relied on outgoing destination information being hidden in restricted mode. However, I will note that fetching ephemeral transaction private keys is NOT restricted, so if an adversary has access to a restricted RPC wallet, then they can already associate outgoing enotes with public Monero addresses, assuming that they already know of the public Monero address.