Merged
Conversation
- Extended RequestOptions interface to include optional timeout parameter in milliseconds - Implemented timeout logic with AbortController in request() method - Implemented timeout logic with AbortController in rawRequest() method - Added comprehensive test coverage for timeout scenarios - Tests cover: successful requests before timeout, timeout triggering, no timeout, and error handling
AvnerMaster
reviewed
Jan 12, 2026
RomKadria
reviewed
Jan 12, 2026
RomKadria
reviewed
Jan 19, 2026
RomKadria
reviewed
Jan 19, 2026
RomKadria
reviewed
Jan 19, 2026
RomKadria
reviewed
Jan 19, 2026
RomKadria
reviewed
Jan 19, 2026
RomKadria
reviewed
Jan 19, 2026
RomKadria
reviewed
Jan 19, 2026
RomKadria
reviewed
Jan 19, 2026
RomKadria
reviewed
Jan 20, 2026
Comment on lines
+11
to
+17
| ``` | ||
| import { ApiClient } from '@mondaydotcomorg/api'; | ||
|
|
||
| const client = new ApiClient({token: '<API-TOKEN>'}); | ||
|
|
||
| client.request('<QUERY>', undefined, { timeout: 20_000 }) | ||
| ``` |
Collaborator
There was a problem hiding this comment.
I mesant this can be cool in the readme, not only changelog, or atleast jutt mention the option in the readme
Collaborator
Author
There was a problem hiding this comment.
Added also example to README
RomKadria
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to specify timeout for GraphQL queries.