Potential fix for code scanning alert no. 4: Information exposure through a stack trace#200
Draft
Tung-Huynh-Shopmacher wants to merge 1 commit intomainfrom
Draft
Potential fix for code scanning alert no. 4: Information exposure through a stack trace#200Tung-Huynh-Shopmacher wants to merge 1 commit intomainfrom
Tung-Huynh-Shopmacher wants to merge 1 commit intomainfrom
Conversation
…ough a stack trace Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/mollie/commercetools-connector/security/code-scanning/4
In general, the issue should be fixed by not sending the raw caught exception object back to the client. Instead, log the full error (including stack trace) on the server, and return a sanitized, generic error response to the client. This avoids exposing stack traces or other sensitive internal details while preserving debuggability via server logs.
Concretely, in
processor/src/controllers/connector.controller.ts, themollieStatuscontroller should be updated so that thecatchblock uses the sameapiError(response, formatErrorResponse(error).errors);pattern used byhealthCheck,install, anduninstall. This keeps behavior consistent across the controller, maintains existing logging (logger.error(...)), and relies on the existing error formatting logic to decide what is safe to expose. The only necessary code change is to replaceresponse.status(400).json(error).send();with theapiErrorcall. No new imports or helper methods are required, sinceapiErrorandformatErrorResponseare already imported at the top of the file.Suggested fixes powered by Copilot Autofix. Review carefully before merging.